Re: [PATCH] remoteproc: qcom_q6v5_mss: Release OF node references in init_mem

[Konrad Dybcio]

On 11/6/26 6:45 PM, Anup Vishwakarma wrote:
> q6v5_init_mem() parses the qcom,qaccept-regs and qcom,ext-regs
> (index 1) properties with of_parse_phandle_with_fixed_args(), which
> takes a reference on the returned device-tree node. The two blocks
> copy the integer arguments and never release the node, unlike the
> other parse blocks in the function, which call of_node_put() once the
> node is no longer needed.
> 
> Release the node once the arguments have been copied. The leak
> affects SC7280 boards whose device tree sets these properties.
> 
> Fixes: c842379d00f1 ("remoteproc: mss: q6v5-mss: Add modem support on SC7280")
> Signed-off-by: Anup Vishwakarma <anup.vishwakarma@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad