Re: [PATCH 1/5] gpio: rcar: don't clobber INTMSK when disabling a single line
From: shao.mingyin
Date: Mon Nov 09 2026 - 09:59:45 EST
On Mon, 2026-11-09 at 15:40 +0100, Geert Uytterhoeven wrote:
> Hence setting extra bits in the INTMSK register does not enable all
> other GPIO interrupts.
You're right -- I had the masking semantics backwards. Since only writes
of 0 to INTMSK take effect, the 1s written to the other bits are ignored,
so the existing code masks just the one line; the read-modify-write
changes nothing and there is no bug to fix here.
Please drop the patch. Sorry for the noise, and thanks for digging out
the manual references.
Best,
Shao Mingyin