Re: [PATCH 2/3] drm/xe: Remove driver side resource assignment after BAR resize

[Rodrigo Vivi]

On Mon, Nov 09, 2026 at 03:10:09PM +0200, Ilpo Järvinen wrote:
> pci_resize_resource() assigns the resized BAR and the other BARs it
> released, or restores the original configuration on failure. Calling
> pci_assign_unassigned_bus_resources() after it is redundant. If that
> call manages to assign more resources in some scenario, the problem
> should be fixed inside pci_resize_resource() instead.
> 
> Remove the pci_assign_unassigned_bus_resources() call from
> xe_pci_rebar_resize().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

feel free to take it through your trees

> ---
>  drivers/gpu/drm/xe/xe_pci_rebar.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci_rebar.c b/drivers/gpu/drm/xe/xe_pci_rebar.c
> index 7e2c7079b6ff..f47b3c039abd 100644
> --- a/drivers/gpu/drm/xe/xe_pci_rebar.c
> +++ b/drivers/gpu/drm/xe/xe_pci_rebar.c
> @@ -100,7 +100,5 @@ void xe_pci_rebar_resize(struct xe_device *xe)
>  	pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd & ~PCI_COMMAND_MEMORY);
>  
>  	resize_bar(xe, LMEM_BAR, rebar_size);
> -
> -	pci_assign_unassigned_bus_resources(pdev->bus);
>  	pci_write_config_dword(pdev, PCI_COMMAND, pci_cmd);
>  }
> -- 
> 2.47.3
>