Re: [PATCH 05/20 v3] sched/eevdf: Add per cpu cached min_slice

[Vincent Guittot]

On Sat, 7 Nov 2026 at 07:53, Kayra Cizmeci <kayracizmeci@xxxxxxxxx> wrote:
>
> On Fri, Nov 06, 2026 at 04:19:32PM +0100, Vincent Guittot wrote:
> > In order to use min_slice during CPU selection, update a cached value when
> > needed after en/dequeing a new task. This cached value includes current
> > task.
> >
> > Signed-off-by: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> > ---
> >  kernel/sched/core.c  |  1 +
> >  kernel/sched/fair.c  | 28 ++++++++++++++++++++++++++++
> >  kernel/sched/sched.h |  1 +
> >  3 files changed, 30 insertions(+)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index d7c3b43158de..031efe7d49fb 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -9012,6 +9012,7 @@ void __init sched_init(void)
> >               rq->sd = NULL;
> >               rq->rd = NULL;
> >               rq->cpu_capacity = SCHED_CAPACITY_SCALE;
> > +             rq->min_slice = ULONG_MAX;
>
> This is already getting changed to 0 in 6/20, instead of changing there,
> wouldn't it be better if we changed it here from the start?

Yes, the rq->min_slice = 0 in patch 6 should have been part of this
patch. I merged it to the wrong patch



>
> Aside from that,
>
> Reviewed-by: Kayra Cizmeci <kayracizmeci@xxxxxxxxx>