Re: [PATCH v3 2/6] leds: aw2013: Add AW2027 support

[Lee Jones]

On Sun, 08 Nov 2026, Paul Sajna wrote:

> On 2026-10-20 3:16 a.m., Lee Jones wrote:
> > This is hard to read, I think we can do better.
> > 
> > Also, does it need to be a separate helper function when it only has a
> > single call site?
> 
> The function is marked inline, so there shouldn't be any performance
> penalty, and I gave it it's own helper function specifically because it's
> hard to read, and giving it a name helps make clearer what it's doing. Do
> you have any suggestions to make it better?

Yes.

- Break it up
- Add more self-describing variables
- Comments if the first two aren't enough

-- 
Lee Jones