Re: [PATCH 4/6] soc: qcom: geni-se: Define the QSPI firmware protocol

From: Jyothi Kumar Seerapu

Date: Mon Nov 09 2026 - 11:55:51 EST



On 11/9/2026 8:17 PM, Konrad Dybcio wrote:
On 11/6/26 4:01 PM, Jyothi Kumar Seerapu wrote:
Add GENI_SE_QSPI with firmware protocol ID 9. The GENI SPI driver uses
this value to request QSPI firmware and validate the protocol running
on a serial engine.

Extend the firmware loader's protocol-name table to accept QSPI.
Reject unused protocol IDs in the sparse table before looking up
firmware.

Signed-off-by: Jyothi Kumar Seerapu <jyothi.seerapu@xxxxxxxxxxxxxxxx>
---
drivers/soc/qcom/qcom-geni-se.c | 7 +++++--
include/linux/soc/qcom/geni-se.h | 1 +
2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index 873bfbd6b2b7..396f3d81d292 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -122,7 +122,10 @@ struct geni_se_desc {
static const char * const icc_path_names[] = {"qup-core", "qup-config",
"qup-memory"};
-static const char * const protocol_name[] = { "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE" };
+static const char * const protocol_name[] = {
+ "None", "SPI", "UART", "I2C", "I3C", "SPI SLAVE",
+ [GENI_SE_QSPI] = "QSPI",
+};

Please use designated initializers for all values here
Hi Konrad,

Agreed. I will use designated initializers for all entries as mentioned below in v2.

static const char * const protocol_name[] = {
[GENI_SE_NONE] = "None",
[GENI_SE_SPI] = "SPI",
[GENI_SE_UART] = "UART",
[GENI_SE_I2C] = "I2C",
[GENI_SE_I3C] = "I3C",
[GENI_SE_SPI_SLAVE] = "SPI SLAVE",
[GENI_SE_QSPI] = "QSPI",
};

Thanks,
JyothiKumar>
Konrad