Re: [PATCH] drm/sun4i: dw-hdmi: Deinit PHY in bind error path
From: Chen-Yu Tsai
Date: Mon Nov 09 2026 - 12:03:13 EST
On Thu, Nov 5, 2026 at 3:57 AM Jernej Skrabec <jernej.skrabec@xxxxxxxxx> wrote:
>
> sun8i_hdmi_phy_init() enables the PHY clocks and deasserts the PHY
> reset. When dw_hdmi_bind() fails afterwards, the error path doesn't
> undo that, so the clocks stay enabled and every further bind attempt
> enables them once more.
>
> Call sun8i_hdmi_phy_deinit() in the error path, like unbind does.
>
> Fixes: c64c8e04a12e ("drm/sun4i: dw-hdmi: Fix HDMI PHY clock setup")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxxxx>