RE: [PATCH net-next v2 2/7] net: ethernet: oa_tc6: Allow custom reset settle time values

[Selvamani Rajagopal]

> -----Original Message-----
> From: Iustin Stolniceanu <iustin.stolniceanu@xxxxxxxxxx>
> Subject: [PATCH net-next v2 2/7] net: ethernet: oa_tc6: Allow custom reset settle time
> values
> 
> diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c
> index 364027c39fa4..549997ba363a 100644
> --- a/drivers/net/ethernet/oa_tc6.c
> +++ b/drivers/net/ethernet/oa_tc6.c
> @@ -89,6 +89,8 @@ struct oa_tc6 {
> bool int_flag;
> bool disable_traffic;
> bool prot_ctrl;
> + u32 hwreset_settle_us;
> + u32 softreset_settle_us;


Should we add the structure "struct oa_tc6_quirks" here, instead of adding three parameters
from that structure, which would 1) make copying easier. 2) Avoid future changes to the oa_tc6
structure, in case more elements gets added in oa_tc6_quirks structure.


> enum oa_tc6_quirk_flag quirk_flags;
> struct gpio_desc *reset_gpio;
> };
> 
> struct oa_tc6 *oa_tc6_init(struct spi_device *spi, struct net_device *netdev,
> --
> 2.43.0