Re: [PATCH v2 2/4] media: qcom: camss: vfe-4-1: program the RDI write master buffer size

From: Allan Siriani

Date: Mon Nov 09 2026 - 12:25:52 EST


On 09/11/2026 12:57, Bryan O'Donoghue wrote:
> Requires a Fixes: tag

Fixes: 4c98a5f57f90 ("media: camss: Add VFE files")

> This feels like a slop-comment which is no bueno

Agreed, it adds nothing. Dropped in v3, together with the comment above
the function.

> (pix->height - 1) << 4
>
> Silently truncating here is incorrect.

Done, v3 writes (pix->height - 1) << 4 as vfe_wm_line_based() does.