Re: [PATCH v1 06/10] kconfig-checker: Split schema to support component reuse

From: Ahmed S. Darwish

Date: Mon Nov 09 2026 - 13:22:32 EST


On Sat, 07 Nov 2026, sashiko-bot@xxxxxxxxxx wrote:
> > +from jsonschema import Draft7Validator
>
> [Severity: Low]
> Does this import need a "# type: ignore" comment to match the earlier
> "import jsonschema" statement?
>

I don't think so, as mypy does not complain in this situation:

$ mypy --version

mypy 2.4.0 (compiled: no)

$ mypy --strict --no-warn-return-any tools/kconfig-checker/check.py

Success: no issues found in 1 source file

So I'll keep this as-is.

>
> [Severity: Low]
> Schema.as_dict() has no remaining callers in this patch or later in the
> series and could be removed.
>

Correct, will remove it.

>
> [Severity: Low]
> Should Documentation/tools/kconfig_checker.rst also be updated here now
> that tools/kconfig-checker/schema.yml has moved to
> tools/kconfig-checker/schemas/base.yml and
> tools/kconfig-checker/schemas/rules.yml?
>

Correct, the documentation should be updated in this very same patch
(instead of updating the docs two patches foreward.)

Thanks,
Ahmed