Re: [PATCH netfs v2 1/2] netfs: preserve prepare_write errno on reissue
From: Paulo Alcantara
Date: Mon Nov 09 2026 - 14:16:59 EST
Iván Ezequiel Rodriguez <ivanrwcm25@xxxxxxxxx> writes:
> prepare_write() may call netfs_prepare_write_failed() (FAILED + errno)
> before write_retry calls netfs_reissue_write(). Clearing subreq->error
> to 0 for a clean I/O reissue (82e8885bd763) then makes
> netfs_do_issue_write() terminate with 0. The collector copies
> front->error into stream->error and mapping_set_error(), which ignores
> 0, so writeback failure is silent.
>
> Skip clearing error when NETFS_SREQ_FAILED is already set;
> do_issue_write() already terminates FAILED subrequests.
>
> Fixes: 82e8885bd763 ("netfs: when subreq is marked for retry, do not check if it faced an error")
> Cc: Shyam Prasad N <sprasad@xxxxxxxxxxxxx>
> Cc: Steve French <stfrench@xxxxxxxxxxxxx>
> Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@xxxxxxxxx>
Applied with R-b from Dave.