Re: [PATCH] arm64: dts: rockchip: use rgmii-id for LubanCat 4 gmac1

[Pufan Jin]

On 2026/11/10 03:55, Andrew Lunn wrote:

> On Tue, Nov 10, 2026 at 03:15:15AM +0800, Pufan Jin wrote:
> > The LubanCat 4 PCB adds ~2ns of trace delay on both TXC and RXC, but
> > that alone is not sufficient for reliable RGMII operation.  With
> > phy-mode = "rgmii" and zero MAC delays the link comes up at 1Gbps but
> > drops ~90% of the packets; the PHY's internal TX/RX delay is required.
> Sorry, but this does not make sense. 4ns of delay is 2ns too many.
>
> You need a proper explanation of what is going on here.
>
>      Andrew

Hi Andrew,

The old comment was wrong. Here is what is actually happening on the
board, with measurements.

Conf A: phy-mode = "rgmii", no tx_delay/rx_delay in the DT.
dwmac-rk programs its defaults tx_delay = 0x30, rx_delay = 0x10; the
PHY's internal delays are disabled. On the board's direct 1Gbps link:

  host -> board ping:  200 sent, 20 received, 90% loss
  board -> host ping:  200 sent, 19 received, 90.5% loss
  mmc_rx_crc_error:    118

Conf B: phy-mode = "rgmii-id".
dwmac-rk programs (0, 0) into the MAC; the PHY inserts its internal
2ns TX/RX delays. On the same direct link:

  host -> board ping:  200/200, 0% loss
  board -> host ping:  200/200, 0% loss
  iperf3 TX:           921 Mbps
  iperf3 RX:           941 Mbps
  mmc_rx_crc_error:    0

The vendor BSP DTS for this board is:

    phy-mode = "rgmii-rxid";
    tx_delay = <0x1b>;
    /* rx_delay = <0x00>; */
    rtl8211f,tx-delay = <0x1b>;

The vendor configures an explicit MAC TX delay and PHY TX/RX delays.
The mainline RTL8211F driver only supports the standard 2ns TX/RX
enable selected by phy-mode; it cannot program the vendor's
fine-grained rtl8211f,tx-delay. With "rgmii-id" the PHY provides the
2ns TX/RX clock delay and the MAC delays are zero, which is the tested
mainline configuration.

The "PCB adds ~2ns" text was never measured and is removed. I will
follow up with a v2 containing the corrected comment and these
measurements.

Pufan