Re: [PATCH] selftests/futex: Skip futex_requeue_pi on unprivileged thread creation

[André Almeida]

Thanks for the patch!

Em 04/11/2026 12:05, Rénich Bon Ćirić escreveu:
> The futex_requeue_pi and futex_requeue_pi_signal_restart selftests
> create threads with the SCHED_FIFO real-time scheduling policy to
> exercise Priority Inheritance futex requeue operations.
>
> When executed without root privileges or in environments lacking the
> CAP_SYS_NICE capability, pthread_create() fails with EPERM. Currently,
> create_rt_thread() asserts that ret == 0, causing all 24 parameterized
> variants in futex_requeue_pi and futex_requeue_pi_signal_restart to fail
> unconditionally. Missing execution permissions should be reported as
> a skip rather than a hard test failure.
>
> Handle EPERM from pthread_create() in create_rt_thread() by invoking
> SKIP() and returning -EPERM. Update callers to check the return value
> and exit early so the test harness records the test as skipped.
> Privileged test execution with CAP_SYS_NICE or root remains unaffected
> and continues to run all test assertions.
>
> Fixes: b7d837c2d49e ("selftests/futex: Migrate futex_requeue_pi to harness")
> Fixes: 7fe733f11215 ("selftests/futex: Migrate futex_requeue_pi_signal_restart to harness")
> Signed-off-by: Rénich Bon Ćirić <renich@xxxxxxxxxxxx>

Reviewed-by: André Almeida <andrealmeid@xxxxxxxxxx>