Re: [PATCH 2/3] platform: arm64: lenovo-thinkpad-t14s: Add Gen 7 EC support

[Abel Vesa]

On 26-11-09 16:14:57, Hans de Goede wrote:
> Hi Abel,
> 
> On 9-Nov-26 15:52, Hans de Goede wrote:
> 
> <snip>
> 
> > For easier review by you I've split the improvements into 4 patches (attached):
> 
> <snip>
> 
> > 4: Cleanup: has_kbd_bl2_and_standby and mic_mute_led_generic checks are
> > really just checks for the original (gen6) support vs gen7 support
> > drop the bools and directly check which variant ec->variant points
> > at instead.
> 
> I accidentally left some debug code in patch 4, attached is a new version.
> 
> 
> <snip>
> 
> > So about these differences:
> > 
> > 1: For the spk / mic mute LEDs, on a hunch I tried using std LED controls
> > with a LED idx/id of 15 for the spk mute LED and that also works.
> > 
> > I did not find either way (REG_AUD vs REG_LED) for the spk mute LED in
> > the DSDT, instead the DSDT ends up sending an ACPI notify event, relying
> > on some windows driver to handle this.
> > 
> > How did you find that REG_AUD still works, did you just try the gen 6
> > method ?
> > 
> > 2: For the kbd backlight, again the DSDT ends up sending an ACPI notify event
> > and does not access the EC itself at all.
> > 
> > How did you find that T14S_EC_REG_KBD_BL1 also works on gen 7?
> 
> One more remark about the kbd-backlight the new mode which reports itself
> as brightness 3 is an auto mode with brightness 2, but it turns off
> the backlight after not using the keyboard for a while (and back on again
> on the next keypress).

Thanks for the pointer. I'll keep it clamped to 2 for now.

Abel