[PATCH 5/5] rtc: gamecube: Use register definitions

From: Thorsten Blum

Date: Mon Nov 09 2026 - 17:46:26 EST


Use the register definitions to replace the hard-coded addresses to
improve readability. Add RTC_SRAM_LAST for the SRAM range end.

Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
---
drivers/rtc/rtc-gamecube.c | 21 +++++++++++----------
1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c
index ec672bee0134..dc4299f71f8f 100644
--- a/drivers/rtc/rtc-gamecube.c
+++ b/drivers/rtc/rtc-gamecube.c
@@ -73,6 +73,7 @@
#define RTC_COUNTER 0x200000
#define RTC_SRAM 0x200001
#define RTC_SRAM_BIAS 0x200004
+#define RTC_SRAM_LAST 0x200010
#define RTC_SNAPSHOT 0x204000
#define RTC_ONTMR 0x210000
#define RTC_OFFTMR 0x210001
@@ -283,11 +284,11 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
}

static const struct regmap_range rtc_rd_ranges[] = {
- regmap_reg_range(0x200000, 0x200010),
- regmap_reg_range(0x204000, 0x204000),
- regmap_reg_range(0x210000, 0x210001),
- regmap_reg_range(0x210004, 0x210007),
- regmap_reg_range(0x21000c, 0x21000d),
+ regmap_reg_range(RTC_COUNTER, RTC_SRAM_LAST),
+ regmap_reg_range(RTC_SNAPSHOT, RTC_SNAPSHOT),
+ regmap_reg_range(RTC_ONTMR, RTC_OFFTMR),
+ regmap_reg_range(RTC_TEST0, RTC_TEST3),
+ regmap_reg_range(RTC_CONTROL0, RTC_CONTROL1),
};

static const struct regmap_access_table rtc_rd_regs = {
@@ -296,10 +297,10 @@ static const struct regmap_access_table rtc_rd_regs = {
};

static const struct regmap_range rtc_wr_ranges[] = {
- regmap_reg_range(0x200000, 0x200010),
- regmap_reg_range(0x204000, 0x204000),
- regmap_reg_range(0x210000, 0x210001),
- regmap_reg_range(0x21000d, 0x21000d),
+ regmap_reg_range(RTC_COUNTER, RTC_SRAM_LAST),
+ regmap_reg_range(RTC_SNAPSHOT, RTC_SNAPSHOT),
+ regmap_reg_range(RTC_ONTMR, RTC_OFFTMR),
+ regmap_reg_range(RTC_CONTROL1, RTC_CONTROL1),
};

static const struct regmap_access_table rtc_wr_regs = {
@@ -312,7 +313,7 @@ static const struct regmap_config gamecube_rtc_regmap_config = {
.val_bits = 32,
.rd_table = &rtc_rd_regs,
.wr_table = &rtc_wr_regs,
- .max_register = 0x21000d,
+ .max_register = RTC_CONTROL1,
.name = "gamecube-rtc",
};