Re: [PATCH] watchdog: gunyah_wdt: Re-enable the watchdog on resume

[Guenter Roeck]

On Mon, Nov 09, 2026 at 08:26:52AM +0000, Stanislav Aleksandrov wrote:
> gunyah_wdt_suspend() disables an active watchdog, and
> gunyah_wdt_resume() enables it again with gunyah_wdt_start(). start()
> first disables the watchdog, which fails with -EINVAL when it is
> already disabled. start() ignores that only while the watchdog is
> inactive, but on resume it is still active for the watchdog core, so
> start() returns before it enables the watchdog:
> 
>   gunyah-wdt gunyah-wdt: gunyah_wdt_start: Failed to stop gunyah wdt -22
> 
> So after every system suspend, the watchdog is left disabled.
> 
> Move setting the timeout and enabling the watchdog into
> gunyah_wdt_enable(), and call it on resume, where the watchdog is
> already disabled.
> 
> Tested on the Samsung Galaxy XR (Qualcomm Halliday) with s2idle and
> deep suspend.
> 
> Fixes: ca316e145c35 ("watchdog: Add driver for Gunyah Watchdog")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@xxxxxxxxx>

Applied.

Thanks,
Guenter