Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags

From: Andy Shevchenko

Date: Mon Nov 09 2026 - 18:45:43 EST


On Tue, Nov 10, 2026 at 01:42:22AM +0200, Andy Shevchenko wrote:
> On Thu, Nov 05, 2026 at 09:27:30AM +0100, Krzysztof Kozlowski wrote:
> > Refactoring of driver subsystems or some core driver parts often come
> > with change of the actual drivers. If that happens within one patch,
> > people giving "Reviewed-by" tag only to piece of the patch, like one
> > driver, and ignoring the rest including the main concept of the patch,
> > are not really reviewing "the patch".
> >
> > As explained in the Submitting Patches document, the "Reviewer's
> > statement of oversight" is for patch as in "entire patch" meaning:
> >
> > (a) I have carried out a technical review of this patch to
> > evaluate its appropriateness and readiness for inclusion into
> > the mainline kernel.
> >
> > The sentence is explicit and complete, meaning it does not allow
> > implicit variations like: "this patch or part of this patch".
> >
> > Reviewing pieces of the patch while ignoring the main part of it, is
> > much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
> > not be applicable.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> And yes, I have read the whole email, including comments.

(even with the commit message that I partially disagree with, the documentation
update at least allows a way out for the cases we are disputing)

--
With Best Regards,
Andy Shevchenko