Re: [PATCH v3 3/3] clk: socfpga: stratix10: register the SP timer clocks early
From: Dinh Nguyen
Date: Mon Nov 09 2026 - 19:33:33 EST
On 10/13/26 02:07, Adrian Ng Ho Yin wrote:
The DW APB timers are probed through TIMER_OF_DECLARE() from time_init()I think this needs a Fixes tag:
and cannot defer, but the clock manager is a platform driver registered
at core_initcall(). The timer's clk_get() therefore fails and the timer
is never brought up.
Register only l4_sp_clk and its parents (boot_clk, main_pll, periph_pll,
main_noc_base_clk, peri_noc_base_clk and noc_free_clk) from
of_clk_init() using CLK_OF_DECLARE_DRIVER(), with every other clock left
as -EPROBE_DEFER. The remaining clocks are still registered when the
platform driver probes, which reuses the early provider.
Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@xxxxxxxxxx>
---
Fixes: 07afb8db7340 ("clk: socfpga: stratix10: add clock driver for Stratix10 platform")
and the Cc: stable
Other than that, it looks good to me.
Dinh