Re: [PATCH v2 00/12] Rust VFIO PCI support and NVIDIA vGPU driver

[Danilo Krummrich]

On Fri Oct 23, 2026 at 5:39 PM CEST, Simon Song wrote:
>   rust: vfio: add PCI variant driver abstractions
>   rust: vfio: use the PCI adapter for variant drivers
>   rust: vfio: separate common device handling from PCI

Those three commits introduce quite some back and forth in terms of deleting and
refactoring previously introduce code.

(I won't review them individually for this reason, but I can go over the end
result and provide some feedback.)

For patch ordering, "rust: vfio: separate common device handling from PCI"
should be the first patch which establishes a shared representation of a base
VFIO device; the other two patches should be squashed into a single patch.

(I think a separate adapter type for vfio-pci could still have some advantages,
but this can be a subsequent consideration, for now I'd stick with the core PCI
one.)

Thanks,
Danilo