Re: [PATCH v15 11/35] firmware: arm_scmi: Add Telemetry groups initialization

[Jonathan Cameron]

On Mon,  9 Nov 2026 09:11:57 +0000
Cristian Marussi <cristian.marussi@xxxxxxx> wrote:

> Allocate and initialize Telemetry Groups from base DataEvent data.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>


> +static int
> +scmi_telemetry_de_groups_init(struct telemetry_info *ti)

one line maybe?  I guess follow local style.

> +{
> +	struct scmi_telemetry_res_info *rinfo;


> @@ -701,6 +833,9 @@ static void scmi_telemetry_resources_free(struct telemetry_info *ti)
>  	kfree(rinfo->des);
>  	kfree(rinfo->dei_store);
>  
> +	kfree(rinfo->grps);
> +	kfree(rinfo->grps_store);

Same as earlier about reverse order being most consistent way to do
release of stuff.

> +
>  	kfree(rinfo);
>  
>  	dev_dbg(ti->ph->dev, "SCMI Telemetry resources freed for instance\n");
> @@ -722,10 +857,25 @@ static void scmi_telemetry_tdes_cleanup(struct telemetry_info *ti)
>  	xa_destroy(&ti->xa_des);
>  }

> +
>  static void scmi_telemetry_instance_cleanup(void *arg)
>  {
>  	struct telemetry_info *ti = arg;
>  
> +	scmi_telemetry_groups_free(ti->rinfo);
>  	scmi_telemetry_tdes_cleanup(ti);
>  	scmi_telemetry_resources_free(ti);
>  }