Re: [PATCH v3 2/9] stop_machine: Add NMI-based execution path

From: Chang S. Bae

Date: Mon Nov 09 2026 - 21:08:35 EST


On 11/6/26 09:44, Nikolay Borisov wrote:

I think this function should be moved over to patch 5 and by having moved/subsumed patch 4, Patch 5 should become patch 3 really so related functionality is introduced in subsequent patches.

Yeah, the suggestion makes sense to me.

On top of this fix,
https://lore.kernel.org/lkml/d81a45f9-1ba2-4eed-92f2-c5152c5caa7b@xxxxxxxxx/

my local pile now has:

* x86/microcode: Remove microcode_nmi_handler_enable
* x86/nmi: Simplify offline microcode handler invocation
* x86/microcode: Use stop-machine NMI facility
* x86/microcode: Distinguish NMI control path on stop-machine callback
* stop_machine: Introduce stop_machine_nmi_cpuslocked()
* stop_machine: Add NMI-based execution path
* x86/nmi: Support NMI stop-machine handler
* x86/apic: Implement self-NMI support
* stop_machine: Define build option for NMI stop-machine
* stop_machine: Refactor multi-CPU stop glue code

I'll post a revision once sorting out the bugfix part and other feedback.

Thanks,
Chang