Re: [PATCH net-next v20 01/13] phylink: Add phylink_mac_interrupt
From: Birger Koblitz
Date: Mon Nov 09 2026 - 23:47:34 EST
On 10/11/2026 2:38 am, netdev-bot+sashiko@xxxxxxxxxx wrote:
Thank you for your contribution! Sashiko AI review found 2 potentialThe possible issues for the series have all been raised before and I have answered to them, some of them more than 4 times. None of these answers are being referred to by the AI, so it does not appear to make sense to provide such answers. Asking nevertheless to answer them again (all medium and above!) constitutes harassment in my eyes.
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 1 · Low: 1
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] phylink_mac_interrupt() (drivers/net/phy/phylink.c:1629-1637)
loads pl->phydev with no lock, no RCU and no reference, then calls…
- [Low] phylink_mac_interrupt() reads pl->phydev with a plain load (`phy
= pl->phydev;`) and no lock.
At this point I am asking a human to intervene and tell me whether anything really still needs to be done.
Birger