[PATCH] drm/amd/display: Don't free devres-owned i2c adapter on init failure
From: yaolu
Date: Tue Nov 10 2026 - 02:13:32 EST
From: Lu Yao <yaolu@xxxxxxxxxx>
amdgpu_dm_connector_init() registers the i2c adapter with
devm_i2c_add_adapter().It will be released by devres on teardown, so
we don't need to free it when failed.
Fixes: 5b3eca05cfb0 ("drm/amd/display: Use devm_i2c_add_adapter to simplify i2c cleanup logic")
Signed-off-by: Lu Yao <yaolu@xxxxxxxxxx>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
index b498fc5fbb14..ccbda54c3add 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
@@ -3514,7 +3514,7 @@ int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm,
if (res) {
drm_err(adev_to_drm(dm->adev), "connector_init failed\n");
aconnector->connector_id = -1;
- goto out_free;
+ return res;
}
drm_connector_helper_add(
--
2.25.1