[RFC PATCH v2 0/6] ksmbd: Windows SIDs for user and group ids

From: Jan Koester

Date: Tue Nov 10 2026 - 02:34:46 EST


Hi,

Windows names owners and ACL entries by SID; for a domain account that
is its objectSid. ksmbd shows a file's owner, group and POSIX ACL
entries as S-1-22 SIDs or as its server domain SID + uid, which a
Windows client can't relate to the domain's accounts, and a SID a client
sets for a domain account doesn't map back to an id at all. This series
lets user space, which knows the directory, translate between ids and
SIDs in both directions, for accounts that are logged in or not.

It applies on top of the UUID/GUID id RFC (uid_r v2,
<cover.1792552161.git.jan.koester@xxxxxxxxx>) and the NTLM pass-through
series (<cover.1792345559.git.jan.koester@xxxxxxx>); the netlink events
it adds follow theirs. Patches 1-3 are independent of uid_r in substance;
I can rebase them onto mainline to go on their own if that is preferred.

Changes since v1
(https://lore.kernel.org/linux-cifs/cover.1793168155.git.jan.koester@xxxxxxxxx/):
- 4/6: the token's SIDs are compared with the ACEs' through a new
exported smb_sid_equal() next to compare_sids(), which also replaces
the private copy of the same comparison in idmap.c. compare_sids()
and its existing callers are unchanged, as some rely on its prefix
matching (Namjae).
- 4/6: the SID mapping stays an on-demand lookup on a cache miss, as
discussed; no change there.
- 4/6 also converts the smb_check_perm_dacl() caller in
smb2_handle_app_instance_id().
- samba-technical dropped from Cc: it only takes mail from subscribers.

1/6 ksmbd ignored the owner and group of a descriptor without a DACL,
which is what Windows sends to take ownership (and smbcacls -C/-G),
and still reported success.

2/6 After setting a POSIX ACL from a DACL, the following chmod used the
owning group's bits as the mask and left named entries without
effect.

3/6 passes the domain of an NTLM login (NTLMSSP DomainName) to user
space in the formerly reserved room of the login request, so a user
space serving several domains can tell DOMAIN\user from OTHER\user.

4/6 adds KSMBD_EVENT_SID_MAP_REQUEST/RESPONSE for a user space that sets
KSMBD_GLOBAL_FLAG_SID_MAP at startup: the SID of an id ksmbd shows,
the id of a domain SID a client sets. Answers are cached (mappings
5 minutes, "none" 1 minute, "couldn't say" never). Showing a
descriptor never fails on a missing mapping; setting one fails with
STATUS_NO_LOGON_SERVERS, STATUS_INVALID_OWNER or
STATUS_INVALID_PRIMARY_GROUP instead of being applied in part or
ignored. The session user also matches ACEs for its groups' SIDs,
like a Windows access token.

5/6 shows classic users as S-1-22-1-<uid> instead of the per-server
domain SID + uid, and still takes the old form.

6/6 documents it in Documentation/userspace-api/uid_r.rst.

The user space side is sharedd (FenrirOS' ksmbd user space) with
adconnect for the directory lookups.

Thanks,
Jan

Jan Koester (6):
ksmbd: don't ignore the owner and group of a descriptor without a DACL
ksmbd: keep named ACL entries effective when a DACL sets a POSIX ACL
ksmbd: pass the domain of an NTLM login to user space
ksmbd: map user and group ids to Windows SIDs through user space
ksmbd: show classic users as S-1-22-1-<uid> on every server
Documentation: uid_r: describe ksmbd's SID mapping

Documentation/userspace-api/uid_r.rst | 18 +-
fs/smb/server/Makefile | 2 +-
fs/smb/server/idmap.c | 315 +++++++++++++++++++++++++++++++++
fs/smb/server/idmap.h | 25 +++
fs/smb/server/ksmbd_netlink.h | 62 ++++++-
fs/smb/server/mgmt/user_config.c | 21 ++-
fs/smb/server/mgmt/user_config.h | 7 +-
fs/smb/server/server.c | 2 +
fs/smb/server/smb2pdu.c | 37 +++-
fs/smb/server/smbacl.c | 267 ++++++++++++++++++++++++----
fs/smb/server/smbacl.h | 19 +-
fs/smb/server/transport_ipc.c | 72 +++++++-
fs/smb/server/transport_ipc.h | 5 +-
13 files changed, 797 insertions(+), 55 deletions(-)
create mode 100644 fs/smb/server/idmap.c
create mode 100644 fs/smb/server/idmap.h

--
2.56.0