Re: [PATCH v2] ASoC: dt-bindings: wm8741: Convert to DT schema
From: Krzysztof Kozlowski
Date: Tue Nov 10 2026 - 03:13:22 EST
On Mon, Nov 09, 2026 at 06:55:22PM +0200, Lorena Tanase wrote:
> Convert the WM8741 audio CODEC bindings to DT schema.
>
> Signed-off-by: Lorena Tanase <tanaselorena3@xxxxxxxxx>
> ---
> .../devicetree/bindings/sound/wlf,wm8741.yaml | 40 +++++++++++++++++++
> .../devicetree/bindings/sound/wm8741.txt | 29 --------------
> 2 files changed, 40 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8741.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/wm8741.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml
> new file mode 100644
> index 000000000000..a9a7fc2414bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8741.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8741.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8741 audio codec
> +
> +description: |
> + Wolfson Microelectronics WM8741 audio CODEC
> +
> +maintainers:
> + - patches@xxxxxxxxxxxxxxxxxxxxx
> +
> +properties:
> + compatible:
> + const: wlf,wm8741
> +
> + reg:
> + maxItems: 1
> +
> +diff-mode:
> + description: diferential output mode
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [0, 1, 2, 3]
You never tested your code.
The main point of this commit is to convert to DT schema, right? So if
you do not test if resulting DT schema is correct, this makes absolutely
no sense. Please read ALL existing docs in DT/bindings directory.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + wm8903: codec@1a {
> + compatible = "wlf,wm8741";
> + reg = <0x1a>;
> +
> + diff-mode = <3>;
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof