Re: [PATCH] ata: libata-core: Add NO_NCQ_TRIM quirk for Samsung PM893 (MZ7L3)

[Tobias Kriebisch]

Hi Niklas,

thanks for the review.

On Mon, Nov 09, 2026 at 03:56:41PM +0100, Niklas Cassel wrote:
> Please boot the latest kernel, 7.4-rc2, and verify that the problem still
> exists.

The three drives hold a ZFS pool on a production server. OpenZFS does
not support 7.4 yet (the latest release supports up to 6.19), so I
cannot run 7.4-rc2 on that machine, and I don't have a spare machine
with this drive and controller.

Would results from the newest kernel that a released OpenZFS supports
be acceptable? On that kernel I can test noncqtrim and nolpm separately,
and then boot a kernel with only the needed quirks and no libata.force.

> If the problem still exist on the latest kernel, apply the minimal set of
> quirks needed to fix the problem.

Understood, the v2 will only contain the quirks that are actually needed.

> And yes, build and boot a kernel with your patch to verify that the 
problem
> is actually solved.

If testing on 6.19 is helpful here, I will build and boot 6.19 with the
patch, verify that the problem is solved, and send a v2 with the results.

Kind regards,
Tobias

--