Re: [PATCH v5 3/3] regulator: Add TI LM51772 support

[Paul Louvel]

Hello Mark,

On Fri Nov 6, 2026 at 12:17 PM CET, Paul Louvel wrote:
> On Fri Nov 6, 2026 at 11:12 AM CET, Paul Louvel wrote:
>> +static const struct regulator_desc lm51772_regulator_template[] = {
>> +	{ .name = "vout",
>> +	  .of_match = of_match_ptr("vout"),
>> +	  .of_parse_cb = lm51772_vout_of_parse,
>> +	  .regulators_node = of_match_ptr("regulators"),
>> +	  .id = 0,
>> +	  .type = REGULATOR_VOLTAGE,
>> +	  .owner = THIS_MODULE,
>> +	  .linear_ranges = lm51772_voltage_ranges,
>> +	  .linear_range_selectors_bitfield = lm51772_voltage_ranges_sel,
>> +	  .n_linear_ranges = ARRAY_SIZE(lm51772_voltage_ranges),
>> +	  .n_voltages = 100 + 2301 + 165 + 2236,
>> +	  .vsel_reg = LM51772_REG_VOUT_TARGET1_LSB,
>> +	  .vsel_mask = LM51772_VOUT_TARGET1_MASK,
>> +	  .vsel_reg_oversize = true,
>> +	  .vsel_range_reg = LM51772_REG_MFR_SPECIFIC_D8,
>> +	  .vsel_range_mask = LM51772_SEL_FB_DIV20,
>> +	  .active_discharge_reg = LM51772_REG_MFR_SPECIFIC_D2,
>> +	  .active_discharge_mask = LM51772_DISCHARGE_CONFIG1 | LM51772_DISCHARGE_CONFIG0,
>> +	  .active_discharge_on =
>> +		  FIELD_PREP_CONST(LM51772_DISCHARGE_CONFIG1, 1) |
>> +		  FIELD_PREP_CONST(LM51772_DISCHARGE_CONFIG0, 1),
>> +	  .active_discharge_off =
>> +		  FIELD_PREP_CONST(LM51772_DISCHARGE_CONFIG1, 0) |
>> +		  FIELD_PREP_CONST(LM51772_DISCHARGE_CONFIG0, 0),

Please find the comment I made to my own patch below.

>
> Maybe would it be better if the core could also change the active discharge
> strength:
>
>   int (*set_active_discharge)(struct regulator_dev *rdev, bool enable,
>             int strength_uA);
>
> That would remove the need for introducing a vendor-specific property:
> 'ti,active-discharge-strength-microamp'.
>

Let me know what you think.

Thanks.
Best regards,
-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com