Re: [PATCH printk 2/6] console: Introduce unsafe flush policy flags
From: John Ogness
Date: Tue Nov 10 2026 - 03:52:42 EST
On 2026-11-10, Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> On Mon, Nov 09, 2026 at 01:37:19PM +0106, John Ogness wrote:
>> Prepare for per-console atomic flushing policies by introducing a
>> new nbcon-specific console field @unsafe_flush_flags to store the
>> unsafe flush policies for a console. The policies are represented
>> by bits, specified by enum nbcon_unsafe_flush_flags.
>>
>> Currently it is expected that any @unsafe_flush_flags bits are set
>> prior to console registration and do not change while registered.
>>
>> No functional change.
>
> ...
>
>> + int unsafe_flush_flags;
>
> Why are flags signed?
It is not relevant and all other flags in struct console are signed, so
I figured it would blend in. I will change it to unsigned for v2.
Thanks for taking a look.
John