Re: [PATCH 1/2] soundwire: Improve channel min/max comments

[Charles Keepax]

On Tue, Nov 10, 2026 at 09:29:00AM +0100, Pierre-Louis Bossart wrote:
> On 11/9/26 18:38, Charles Keepax wrote:
> > Presently, the comments for the minimum and maximum channels are
> > misleading. In the SDCA specification these are actually channel
> > indexes not a count of the number of channels. So for example
> > min_ch=4 and max_ch=5 means that 1 or 2 channels are supported.
> > Update the comments associated with the structure to make this
> > more clear.
> 
> It's the DisCo spec, not SDCA.

Ooops yeah thank you, I will fix.

> > + * @max_ch: Index of the maximum channel supported
> > + * @min_ch: Index of the minimum channel supported
> 
> that's also ambiguous.
> 
> Maybe just use the spec definition "minimum Channel Number of this Audio
> Port"

Yeah I am happy with that wording will update for the spin.

Thanks,
Charles