Re: [PATCH v7 1/8] dt-bindings: media: qcom: Add JPEG encoder binding

[Atanas Filipov]

On Fri, Nov 06, 2026 at 07:31:43AM -0600, Rob Herring wrote:
>> +      - const: camnoc_axi
>> +      - const: camnoc_axi_src
>
> These 2 don't sound like clocks that are part of this block. And 'src'
> sounds like the parent clock? Use assigned-clocks for parent clocks (or
> just retrieve the parent from the clk api).

Right, camnoc_axi_src is the parent of camnoc_axi. I will drop it from
the binding in v8.

For the encoder, camnoc_axi alone would be enough, as its memory
traffic goes through the camera NoC. The problem is CAMSS: on SM8250
it sets the rate of camnoc_axi_src directly, and a rate range on
camnoc_axi does not limit that. So the driver keeps its minimum rate
on the parent. In v8 it gets the parent with clk_get_parent(), so DT
does not need the extra clock.

>> +      - const: core
>
> I would expect the main clock for the block to come first in the list,
> not last.

OK, I will move core to the first place in v8.

Thanks,
Atanas