Re: [PATCH net-next v3 2/5] dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml
From: Krzysztof Kozlowski
Date: Tue Nov 10 2026 - 05:32:26 EST
On Fri, Nov 06, 2026 at 08:47:26AM +0100, Steffen Trumtrar wrote:
> The binding has neither a compatible nor a select, so dtschema never
> applies it to a node: neither the example nor any devicetree is checked
> against it.
>
> Add the compatible of the PHY ID, optionally followed by the generic
> ethernet-phy-ieee802.3-c22, which several devicetrees use. Select on the
> PHY ID only, as the fallback alone would select every clause 22 PHY.
> Nodes without a compatible stay valid, but are not checked.
>
> The binding also references ethernet-controller.yaml, which describes
> MACs; its node name pattern does not match a PHY node. Reference
> ethernet-phy.yaml instead, which also describes reset-gpios and the
> other generic PHY properties existing devicetrees use.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/ti,dp83867.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof