Re: [PATCH net-next v3 3/5] dt-bindings: net: dp83867: make exclusivity explicit
From: Krzysztof Kozlowski
Date: Tue Nov 10 2026 - 05:43:44 EST
On Fri, Nov 06, 2026 at 08:47:27AM +0100, Steffen Trumtrar wrote:
> The io_impedance_ctrl nvmem cell and the properties
> ti,{min,max}-output-impedance are mutually exclusive, as noted in the
> ti,max-output-impedance description.
But it also said it is allowed and one will be chosen over other, if
both present.
>
> As this is only stated in the description and not made explicit in the
> schema, the binding checker will not catch if this condition is ignored.
>
> Make it explicit in the schema that only one of them can be used. With
> that, drop the note, which also described a precedence for device trees
> that the schema now rejects.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/ti,dp83867.yaml | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> index 2cd8311ece5e..833540743bdf 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -7,9 +7,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: TI DP83867 ethernet PHY
>
> -allOf:
> - - $ref: ethernet-phy.yaml#
You just added it, so instead place it at the end in previous patch.
Best regards,
Krzysztof