Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc

[Uwe Kleine-König]

Hello,

On Mon, Nov 09, 2026 at 07:44:12PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 08, 2026 at 09:32:10AM +0100, Uwe Kleine-König wrote:
> > On Sun, Nov 08, 2026 at 01:32:18AM +0000, Jonathan Cameron wrote:
> > > On Thu, 5 Nov 2026 16:42:42 +0100
> > > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> > > 
> > > > On Fri, Oct 30, 2026 at 05:47:04PM +0100, Maxime Chevallier wrote:
> > > > > +#include <linux/i2c.h>
> > > > > +#include <linux/mod_devicetable.h>  
> > > > 
> > > > Please don't include <linux/mod_devicetable.h>. <linux/i2c.h> already
> > > > provides i2c_device_id and of_device_id. <linux/mod_devicetable.h>
> > > > provides many more *_device_id and thus introduces a big list of
> > > > unnecessary dependencies.
> > > > 
> > > > I recommend to just drop <linux/mod_devicetable.h> here. If you insist
> > > > on full iwyu, there is <linux/device-id/i2c.h> and
> > > > <linux/device-id/of.h>.
> 
> It must also imply acpi.h.

That's true, but irrelevant for the patch under discussion because it
doesn't use acpi stuff. So at least here even with full iwyu you don't
need to care about <linux/acpi.h> or <linux/device-id/acpi.h>.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature