Re: [PATCH can-next v5 6/6] can: gs_usb: fix hardware timestamp state for mixed channels

From: Marc Kleine-Budde

Date: Tue Nov 10 2026 - 06:05:20 EST


On 10.11.2026 09:52:08, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 2
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The patch is meant to stop RX timestamp conversion from using an
> uninitialized parent->tc when a non-TS channel is opened before a TS…
> - [Low] gs_usb_probe() (drivers/net/can/usb/gs_usb.c) declares `bool
> ts_supported;` at line 1544 with no initializer.
> - [Low] The comment on tc_lock in struct gs_usb
> (drivers/net/can/usb/gs_usb.c:335, `spinlock_t tc_lock; /* spinlock to…

good bot! Valid findings, will fix.

pw-bot: cr

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature