Re: [PATCH net-next 07/14] mptcp: annotate data-races around pernet sysctls

[Matthieu Baerts]

Hi Jiayuan,

Thank you for the patch!

On 09/11/2026 03:52, Jiayuan Chen wrote:
> enabled, add_addr_timeout, checksum_enabled, allow_join_initial_addr_port,
> stale_loss_cnt, close_timeout, pm_type and syn_retrans_before_tcp_fallback
> are read by their ctrl.c helpers without any lock while the sysctl
> handlers update them with WRITE_ONCE(), and the path_manager handler
> stores pm_type with a plain write. Add READ_ONCE() to the readers and
> WRITE_ONCE() to that handler.
I have the same patch on the MPTCP ML (the WRITE_ONCE() is split in
another one):


https://lore.kernel.org/e8335e14eff144774aec63393f5cce13e69dddc0.1790147728.git.yangang@xxxxxxxxxx

So that's good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>

Note that my patch was still in review because Sashiko kept complaining
that this was not fixing all issues, e.g. the new WRITE_ONCE() you
introduced is not enough. Gang has a fix for that [1], and that's not
blocking your patch.

[1]
https://lore.kernel.org/c9f533ea507e6a88d3401768785153a63790c3d8.1790147728.git.yangang@xxxxxxxxxx

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.