Re: [PATCH net] selftests: bonding: feed link monitor to deflake prio_test
From: Bjoern Doebel
Date: Tue Nov 10 2026 - 07:06:05 EST
Hi Hangbin,
On Thu, Nov 05, 2026 at 10:19:08AM +0800, Hangbin Liu wrote:
> If the kill fails for some reason, will we wait here forever and hang the
> entire test?
No. bash keeps a terminated child's exit status until it is reaped, so if
the ping already exited the kill fails but the wait returns immediately.
Only a genuinely unkillable ping would block, independent of kill. The
idiomatic form is kill_process() from net/lib.sh, which short-circuits
the wait when the kill fails.
Let's disregard v1 anyway. Your question made me look again, and it only
treats a symptom: the Sashiko review was right that the mechanism in my
commit message was wrong. I'll follow-up.
pw-bot: cr
Thanks,
Bjoern