RE: [PATCH] drm: renesas: rz-du: mipi-dsi: Drop duplicate platform_set_drvdata() call
From: Biju Das
Date: Tue Nov 10 2026 - 07:11:37 EST
Hi Prabhakar,
Thanks for the patch.
> -----Original Message-----
> From: Prabhakar <prabhakar.csengg@xxxxxxxxx>
> Sent: 10 November 2026 11:46
> Subject: [PATCH] drm: renesas: rz-du: mipi-dsi: Drop duplicate platform_set_drvdata() call
>
> From: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
>
> The platform driver data is already set earlier in rzg2l_mipi_dsi_probe(). The subsequent
> platform_set_drvdata() call uses the same arguments and is therefore redundant.
>
> Remove the duplicate call.
Some thread related to the patch [1]. Can you please drop the first one and keep the second
one?
[1] https://lore.kernel.org/all/TY6PR01MB173770FD0BA340F5A50633E21FF322@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
Cheers,
Biju
>
> Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rz-
> du/rzg2l_mipi_dsi.c
> index 5b257f5adf06..985d6e02203c 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> @@ -1576,8 +1576,6 @@ static int rzg2l_mipi_dsi_probe(struct platform_device *pdev)
> if (!dsi->dcs_buf_virt)
> return -ENOMEM;
>
> - platform_set_drvdata(pdev, dsi);
> -
> ret = rzg2l_mipi_dsi_pwrrdy_init(dsi);
> if (ret)
> return ret;
> --
> 2.56.0