[PATCH] alarmtimer: Initialize the device wakeup after the RTC device was chosen

From: Thomas Weißschuh

Date: Tue Nov 10 2026 - 07:33:14 EST


Currently device_init_wakeup() is called before try_module_get().
If try_module_get() fails the wakeup enablement has been pointless.

Only call device_init_wakeup() after the device has been chosen as RTC
device definitively.

Suggested-by: Thomas Gleixner <tglx@xxxxxxxxxx>
Link: https://lore.kernel.org/lkml/878q31vl8g.ffs@fw13/
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
kernel/time/alarmtimer.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index ecf8c89f7eaf..da6b3024406c 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -91,13 +91,12 @@ static int alarmtimer_rtc_add_device(struct device *dev)
if (IS_ERR(pdev))
return PTR_ERR(pdev);

- device_init_wakeup(&pdev->dev, true);
-
if (!try_module_get(rtc->owner)) {
platform_device_unregister(pdev);
return -1;
}

+ device_init_wakeup(&pdev->dev, true);
WRITE_ONCE(rtcdev, rtc);
/* Hold a reference so it doesn't go away */
get_device(dev);

---
base-commit: 0359ecff58853a491dd0f09792fea8e87235ae06
change-id: 20261110-alarmtimer-wakeup-5543cae6572c

Best regards,
--
Thomas Weißschuh <linux@xxxxxxxxxxxxxx>