Re: [PATCH v2 3/3] i2c: dev: clean up registration
From: Wolfram Sang
Date: Tue Nov 10 2026 - 07:43:22 EST
On Thu, Aug 27, 2026 at 12:20:43PM +0200, Johan Hovold wrote:
> Drop the get_free_i2c_dev() and put_i2c_dev() helpers and do all setup
> and teardown directly in i2cdev_attach_adapter() and
> i2cdev_detach_adapter() for consistency and to make the logic clearer.
>
> Note that the device list is only used at detach so the i2c-dev can be
> added after registering the class device.
Can we have the last sentence as a comment in the code, too, please?
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Other than that, I think this patch is an improvement. The logic is more
explicit. I didn't like 'put_i2c_dev' having a bool parameter, for
example.
So, only patch 1 needs a bigger update, it seems. Rest is looking good
to me.