Re: [PATCH v3] staging: octeon: remove unnecessary parentheses

From: Alejandro Lucero

Date: Tue Nov 10 2026 - 07:43:56 EST


Hi Dan,

You are right. I ran it again with --strict and
got 0 checks.

I was analyzing the file based on the previous automated revisions
I sent, which tried to clean up things that checkpatch don't
complain about.

Thanks for the clarification, and sorry for sending unnecessary
noise T-T

Regards,
Alejandro Lucero

El mar, 10 nov 2026 a la(s) 6:19 a.m., Dan Carpenter (dan@xxxxxxxxxxx) escribió:
>
> On Tue, Nov 10, 2026 at 03:37:24AM -0600, Oscar Alejandro Sánchez Lucero via B4 Relay wrote:
> > From: Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>
> >
> > Fix checkpatch.pl warnings by removing redundant parentheses around
> > conditional checks.
> >
> > Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>
> > ---
>
> Search for this on lore.
>
> https://lore.kernel.org/all/?q=cvm_oct_common_change_mtu
>
> I don't even know how you are seeing these warnings because I
> changed checkpatch to not warn about it.
>
> dcarpenter@stanley:~/progs/kernel/devel$ ./scripts/checkpatch.pl -f --strict drivers/staging/octeon/ethernet.c
> total: 0 errors, 0 warnings, 0 checks, 1037 lines checked
>
> drivers/staging/octeon/ethernet.c has no obvious style problems and is ready for submission.
>
> regards,
> dan carpenter
>
>
>