[PATCH v3 8/8] media: i2c: ov9282: harmonize dev_err_probe usage
From: Richard Leitner
Date: Tue Nov 10 2026 - 08:26:52 EST
Use dev_err_probe() for all error messages during probing. This ensures
there's a common "look-and-feel" in the drivers source code as well as
the system log.
Reviewed-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxx>
---
drivers/media/i2c/ov9282.c | 32 +++++++++++++++-----------------
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c
index d24fcdd4bcc33..59443b18d83cc 100644
--- a/drivers/media/i2c/ov9282.c
+++ b/drivers/media/i2c/ov9282.c
@@ -1079,9 +1079,8 @@ static int ov9282_parse_hw_config(struct ov9282 *ov9282)
ov9282->reset_gpio = devm_gpiod_get_optional(ov9282->dev, "reset",
GPIOD_OUT_LOW);
if (IS_ERR(ov9282->reset_gpio)) {
- dev_err(ov9282->dev, "failed to get reset gpio %pe",
- ov9282->reset_gpio);
- return PTR_ERR(ov9282->reset_gpio);
+ return dev_err_probe(ov9282->dev, PTR_ERR(ov9282->reset_gpio),
+ "failed to get reset gpio\n");
}
/* Get sensor input clock */
@@ -1097,8 +1096,8 @@ static int ov9282_parse_hw_config(struct ov9282 *ov9282)
rate = clk_get_rate(ov9282->inclk);
if (rate != OV9282_INCLK_RATE) {
- dev_err(ov9282->dev, "inclk frequency mismatch");
- return -EINVAL;
+ return dev_err_probe(ov9282->dev, -EINVAL,
+ "inclk frequency mismatch\n");
}
ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
@@ -1114,16 +1113,15 @@ static int ov9282_parse_hw_config(struct ov9282 *ov9282)
bus_cfg.bus.mipi_csi2.flags & V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK;
if (bus_cfg.bus.mipi_csi2.num_data_lanes != OV9282_NUM_DATA_LANES) {
- dev_err(ov9282->dev,
- "number of CSI2 data lanes %d is not supported",
- bus_cfg.bus.mipi_csi2.num_data_lanes);
- ret = -EINVAL;
+ ret = dev_err_probe(ov9282->dev, -EINVAL,
+ "number of CSI2 data lanes %d is not supported\n",
+ bus_cfg.bus.mipi_csi2.num_data_lanes);
goto done_endpoint_free;
}
if (!bus_cfg.nr_of_link_frequencies) {
- dev_err(ov9282->dev, "no link frequencies defined");
- ret = -EINVAL;
+ ret = dev_err_probe(ov9282->dev, -EINVAL,
+ "no link frequencies defined\n");
goto done_endpoint_free;
}
@@ -1354,8 +1352,8 @@ static int ov9282_probe(struct i2c_client *client)
ret = ov9282_parse_hw_config(ov9282);
if (ret) {
- dev_err(ov9282->dev, "HW configuration is not supported");
- return ret;
+ return dev_err_probe(ov9282->dev, ret,
+ "HW configuration is not supported\n");
}
ov9282->regmap = devm_cci_regmap_init_i2c(client, 16);
@@ -1366,12 +1364,12 @@ static int ov9282_probe(struct i2c_client *client)
ret = ov9282_power_on(ov9282->dev);
if (ret)
return dev_err_probe(ov9282->dev, ret,
- "failed to power-on the sensor");
+ "failed to power-on the sensor\n");
/* Check module identity */
ret = ov9282_detect(ov9282);
if (ret) {
- dev_err(ov9282->dev, "failed to find sensor: %d", ret);
+ dev_err_probe(ov9282->dev, ret, "failed to find sensor\n");
goto error_power_off;
}
@@ -1381,7 +1379,7 @@ static int ov9282_probe(struct i2c_client *client)
ret = ov9282_init_controls(ov9282);
if (ret) {
- dev_err(ov9282->dev, "failed to init controls: %d", ret);
+ dev_err_probe(ov9282->dev, ret, "failed to init controls\n");
goto error_power_off;
}
@@ -1394,7 +1392,7 @@ static int ov9282_probe(struct i2c_client *client)
ov9282->pad.flags = MEDIA_PAD_FL_SOURCE;
ret = media_entity_pads_init(&ov9282->sd.entity, 1, &ov9282->pad);
if (ret) {
- dev_err(ov9282->dev, "failed to init entity pads: %d", ret);
+ dev_err_probe(ov9282->dev, ret, "failed to init entity pads\n");
goto error_handler_free;
}
--
2.53.0