Re: [PATCH v3 5/6] mm: gup: introduce gup_unshared_pages()

From: David Hildenbrand (Arm)

Date: Tue Nov 10 2026 - 08:35:33 EST


On 11/10/26 10:58, Yeoreum Yun wrote:
> Hi Rik,
>
>> On Mon, 2026-11-09 at 12:32 +0000, Yeoreum Yun wrote:
>>> This is preparatory patch to make gup_fast_pte_range() batchable.
>>>
>>> Introduce gup_unshared_pages() to count consecutive pages within a
>>> folio
>>> that do not require unsharing, and use it to implement
>>> gup_must_unshare().
>>>
>> Could gup_exclusive_pages() be a better name?
>
> Yes. This seems much better for me. I'll change it in next-spin.

Not quite the right semantics. For pagecache folios we simply don't need
unsharing in MAP_SHARED VMAs. That does not imply that these are exclusive.

So it's all about "number of pages that don't need unsharing".

Any idea for a fitting name ? :)

--
Cheers,

David