Re: [PATCH v2 7/8] reset: zynq: Use regmap_test_bits in zynq_reset_status

[Michal Simek]

On 11/9/26 17:50, Philipp Zabel wrote:
> Simplify zynq_reset_status() by using regmap_test_bits().
> No functional change.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>   drivers/reset/reset-zynq.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/reset/reset-zynq.c b/drivers/reset/reset-zynq.c
> index 688b512882ec..b7a0445aafcf 100644
> --- a/drivers/reset/reset-zynq.c
> +++ b/drivers/reset/reset-zynq.c
> @@ -67,17 +67,11 @@ static int zynq_reset_status(struct reset_controller_dev *rcdev,
>   
>   	int bank = id / BITS_PER_LONG;
>   	int offset = id % BITS_PER_LONG;
> -	int ret;
> -	u32 reg;
>   
>   	pr_debug("%s: %s reset bank %u offset %u\n", KBUILD_MODNAME, __func__,
>   		 bank, offset);
>   
> -	ret = regmap_read(priv->slcr, priv->offset + (bank * 4), &reg);
> -	if (ret)
> -		return ret;
> -
> -	return !!(reg & BIT(offset));
> +	return regmap_test_bits(priv->slcr, priv->offset + (bank * 4), BIT(offset));
>   }
>   
>   static const struct reset_control_ops zynq_reset_ops = {

Tested-by: Michal Simek <michal.simek@xxxxxxx>

Thanks,
Michal