Re: [PATCH v2] mm/slub: Genericize x86-specific cmpxchg16b comment

[Harry Yoo]

On Tue, Nov 10, 2026 at 03:05:14PM +0800, Hao Li wrote:
> On Tue, Nov 10, 2026 at 09:29:04AM +0800, Tiezhu Yang wrote:
> > On 11/10/26 2:25 AM, Alexei Starovoitov wrote:
> > > On Sun, Nov 08, 2026 at 07:59 PM Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
> > > > atomic primitive is satisfied by different hardware implementations:
> > > > (1) arm64: satisfies it via LSE atomics ('casp' instruction)
> > > [...]
> > > > Update the comment to "double-width atomic cmpxchg", which provides the
> > > > following advantages:
> > > > (1) Accurately describes the cross-platform hardware invariant.
> > > 
> > > You ignored Hao's point about shorter commit logs.
> > 
> > If the following shorter commit message is preferred:
> > 
> >   mm/slub: Genericize x86-specific cmpxchg16b comment
> > 
> >   In __kmalloc_nolock_noprof(), update the comment from x86-specific
> >   "cmpxchg16b" to generic "double-width atomic cmpxchg".
> 
> Ok, LGTM.

Looks good to me too.

> > I will wait for a while for more feedback from mm maintainers and send
> > v3 if necessary.

Please send v3.

> > Thanks,
> > Tiezhu

-- 
Cheers,
Harry / Hyeonggon