Re: [PATCH v2 4/6] dt-bindings: clock: ath79: add the PCIe PLL clock

From: Krzysztof Kozlowski

Date: Tue Nov 10 2026 - 09:08:09 EST


On Mon, Nov 09, 2026 at 05:36:44PM -0800, Rosen Penev wrote:
> Add an ID for the PCIe PLL, which AR724x, AR934x, QCA953x, QCA955x and
> QCA956x have, so the PCIe host controller nodes can reference it.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
> include/dt-bindings/clock/ath79-clk.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/ath79-clk.h b/include/dt-bindings/clock/ath79-clk.h
> index f8a98e4d206d..e4956afd151d 100644
> --- a/include/dt-bindings/clock/ath79-clk.h
> +++ b/include/dt-bindings/clock/ath79-clk.h
> @@ -12,7 +12,8 @@
> #define ATH79_CLK_REF 3
> #define ATH79_CLK_MDIO 4
> #define ATH79_CLK_UART1 5
> +#define ATH79_CLK_PCIE 6

Splitting one define per patch is ridicilous. This is just ONE commit.

>
> -#define ATH79_CLK_END 6
> +#define ATH79_CLK_END 7

You cannot keep changing the ABI.

Best regards,
Krzysztof