Re: [RFC PATCH v2 03/18] fuse: don't move a folio with PG_rcu_free into a fuse file

[Kiryl Shutsemau]

On Mon, Nov 09, 2026 at 06:48:39PM +0100, David Hildenbrand (Arm) wrote:
> On 11/9/26 17:35, Linus Torvalds wrote:
> > On Mon, 9 Nov 2026 at 08:28, Linus Torvalds
> > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >>
> >> On Mon, 9 Nov 2026 at 06:46, David Hildenbrand (Arm) <david@xxxxxxxxxx> wrote:
> >>>
> >>> Could we get rid of fuse_try_move_folio() entirely?
> >>
> >> Please. That would be great.
> > 
> > .. and in a similar vein, we should get rid of splice doing the same entirely.
> > 
> > Kirly's patch to just remove page_cache_pipe_buf_try_steal() entirely
> > (ok, it was originally mine, but Kiryl took ownership of that series:
> > "Tag, you're it") is worth doing, but I think worth doubling down on.
> > I think we sh ould just get rid of 'try_steal' entirely. I don't think
> > anybody really uses it. I think it exists in fuse and in the virtio
> > console, and neither is worth it.
> > 
> > Removing pipe_buf_try_steal() would basically remove all of
> > fuse_try_move_folio().
> > 
> > Conversely, removing fuse_try_move_folio() would make
> > pipe_buf_try_steal() even less useful than it is now.
> > 
> > Just remove them both. Good riddance.
> 
> Yes, that would be very nice.

Agreed.  I will post a separate series that removes ->try_steal and its
users (fuse_try_move_folio(), virtio_console's pipe_to_sg()), with
SPLICE_F_MOVE, SPLICE_F_GIFT and FUSE_SPLICE_MOVE left as no-ops, and
drop patches 2-3 from this series on top of it.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov