Re: [PATCH v3 1/6] ksmbd: verify the signature of session binding requests
From: Namjae Jeon
Date: Tue Nov 10 2026 - 09:42:39 EST
> +static bool smb2_check_binding_sign_req(struct ksmbd_work *work,
> + struct smb2_hdr *hdr,
> + struct ksmbd_session *sess)
> +{
> + struct ksmbd_session *prev_sess = work->sess;
> + char signature[SMB2_SIGNATURE_SIZE];
> + int ret;
> +
> + memcpy(signature, hdr->Signature, SMB2_SIGNATURE_SIZE);
> + work->sess = sess;
> + ret = smb3_check_sign_req(work);
> + work->sess = prev_sess;
> + memcpy(hdr->Signature, signature, SMB2_SIGNATURE_SIZE);
Could we restore hdr->Signature inside smb2_check_sign_req() and
smb3_check_sign_req(), using the existing signature_req buffer? This
would eliminate the extra signature backup and restore code in the
session-setup helper in patch 1/6 and __process_request() in patch
3/6.