Re: [PATCH v15 2/2] clk: scmi: reject SSC configuration out of the OEM field range
From: Cristian Marussi
Date: Tue Nov 10 2026 - 09:54:39 EST
On Wed, Nov 04, 2026 at 11:36:03AM +0100, Dario Binacchi wrote:
> The i.MX SCMI OEM extension stores the spread in an 8-bit field, in
> tenths of a percent, and the modulation frequency in a 16-bit field.
>
> FIELD_PREP() silently truncates values that do not fit in the target
> field. Moreover, the conversion from permyriad to tenths of a percent
> turns values below 10 permyriad into zero, which is then passed to the
> firmware as no spread at all.
>
> Reject these cases with a warning instead of silently programming a
> configuration different from the requested one.
>
> A request with no spread method disables SSC, so send a zeroed
> configuration to the firmware in that case, without checking the
> spread and the modulation frequency, which are meaningless then.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
>
LGTM.
From: Cristian Marussi <cristian.marussi@xxxxxxx>
Thanks,
Cristian