Re: [PATCH v2 bpf-next 18/18] bpftool: List and show fmod_ret targets
From: Anton Protopopov
Date: Tue Nov 10 2026 - 10:27:15 EST
On 26/11/09 05:42PM, bot+bpf-ci@xxxxxxxxxx wrote:
> > bpftool: List and show fmod_ret targets
>
> TL;DR: Nit only: bpftool.rst adds fmodret to the OBJECT list without a
> matching *FMODRET-COMMANDS* line like the other objects have; suggests adding
> one.
>
> > diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst
> > index f38ae5c40439..2c64c22a5026 100644
> > --- a/tools/bpf/bpftool/Documentation/bpftool.rst
> > +++ b/tools/bpf/bpftool/Documentation/bpftool.rst
> > @@ -21,7 +21,7 @@ SYNOPSIS
> > **bpftool** **version**
> >
> > *OBJECT* := { **map** | **prog** | **link** | **cgroup** | **perf** | **net** | **feature** |
> > -**btf** | **gen** | **struct_ops** | **iter** }
> > +**btf** | **gen** | **struct_ops** | **iter** | **fmodret** }
>
> This isn't a bug, but fmodret is added to the OBJECT list without a
> matching *FMODRET-COMMANDS* line. Every other object in that list has
> one (*MAP-COMMANDS*, *PROG-COMMANDS*, ... *ITER-COMMANDS*), as set up by
> commit 6585abea98ae ("bpftool: man: Add missing top level docs").
>
> Should a line like this be added after *ITER-COMMANDS*?
>
> *FMODRET-COMMANDS* := { **list** | **show** | **help** }
>
Yes, thanks, will add
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/42662799554