Re:
From: Joshua Crofts
Date: Tue Nov 10 2026 - 10:28:16 EST
Hi Nick,
Several issues with this patch unfortunately :(
On Tue, 10 Nov 2026 20:33:54 +0630
Nick <nick21042013@xxxxxxxxx> wrote:
> From: Nick <nick21042013@xxxxxxxxx>
>
> Date: Tue, 10 Nov 2026 19:57:26 +0630
>
> Subject: [PATCH] staging: iio: adt7316: fix camelCase violations
This shouldn't be in the body of the commit. Additionally, you're missing a
subject.
>
>
> Rename Vref and AIN to lowercase characters.
>
What's going on with the spacing? This unfortunately fails to apply, as
the patch is malformed. I see that you sent it with git send-email, but
was the patch created correctly with git format-patch?
> This fixes the style violations and brings
>
> the driver into line with the kernel style
>
> guidelines.
>
Additionally, the camelCase is intentional, as this is standard
notation for things like voltages.
>
> Signed-off-by: Nick <nick21042013@xxxxxxxxx>
Also, we need a full name in the Signed-off-by tag.
--
Kind regards,
Joshua Crofts